On Tue, Apr 02, 2013 at 07:09:50AM +0900, Namhyung Kim wrote: > 2013-04-01 (월), 21:18 +0200, Jiri Olsa: > > Moving programs check into config/Makefile. > > [SNIP] > > > +RM = rm -f > > +MKDIR = mkdir > > +FIND = find > > +INSTALL = install > > +FLEX = flex > > +BISON = bison > > +STRIP ?= strip > > Why does STRIP use "?=" form? > > I know you just moved the line, but AFAICS it can be converted to a > normal variable assignment, right?
not sure, I guess someone found usefull to use custom strip > > > > @@ -140,14 +140,6 @@ ifneq ($(MAKECMDGOALS),clean) > > ifneq ($(MAKECMDGOALS),tags) > > -include config/feature-tests.mak > > > > -ifeq ($(call get-executable,$(FLEX)),) > > - dummy := $(error Error: $(FLEX) is missing on this system, please > > install it) > > -endif > > - > > -ifeq ($(call get-executable,$(BISON)),) > > - dummy := $(error Error: $(BISON) is missing on this system, please > > install it) > > -endif > > - > > ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror > > -fstack-protector-all,-fstack-protector-all),y) > > CFLAGS := $(CFLAGS) -fstack-protector-all > > endif > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > > index fe317c2..04bf8ac 100644 > > --- a/tools/perf/config/Makefile > > +++ b/tools/perf/config/Makefile > > @@ -32,3 +32,13 @@ endif > > ifeq ($(NO_PERF_REGS),0) > > BASIC_CFLAGS += -DHAVE_PERF_REGS > > endif > > + > > +-include config/feature-tests.mak > > It seems now it's redundant to include this file? The 'config/feature-tests.mak' stuff is still needed for the rest of the Makefile at this point. Althought all the checking stuff is moved with final patch into config/Makefile, I wanted middle commit to stay functional. Now I wonder if I include 'config/feature-tests.mak' from 'config/Makefile' wether it afects top level Makefile environment or not (my initial thought). I'll double check that and remove if necessary. thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
