On Sun, Mar 31, 2013 at 10:59:47PM +0800, Axel Lin wrote: > We can test PWMF_ENABLED bit to know if pwm is enabled or not. > Thus remove enabled field from struct imx_chip. > > Signed-off-by: Axel Lin <[email protected]>
Looks good. Acked-by: Sascha Hauer <[email protected]> Sascha > --- > drivers/pwm/pwm-imx.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c > index 3f5677b..ec28798 100644 > --- a/drivers/pwm/pwm-imx.c > +++ b/drivers/pwm/pwm-imx.c > @@ -43,7 +43,6 @@ struct imx_chip { > struct clk *clk_per; > struct clk *clk_ipg; > > - int enabled; > void __iomem *mmio_base; > > struct pwm_chip chip; > @@ -135,7 +134,7 @@ static int imx_pwm_config_v2(struct pwm_chip *chip, > MX3_PWMCR_DOZEEN | MX3_PWMCR_WAITEN | > MX3_PWMCR_DBGEN | MX3_PWMCR_CLKSRC_IPG_HIGH; > > - if (imx->enabled) > + if (test_bit(PWMF_ENABLED, &pwm->flags)) > cr |= MX3_PWMCR_EN; > > writel(cr, imx->mmio_base + MX3_PWMCR); > @@ -186,8 +185,6 @@ static int imx_pwm_enable(struct pwm_chip *chip, struct > pwm_device *pwm) > > imx->set_enable(chip, true); > > - imx->enabled = 1; > - > return 0; > } > > @@ -198,7 +195,6 @@ static void imx_pwm_disable(struct pwm_chip *chip, struct > pwm_device *pwm) > imx->set_enable(chip, false); > > clk_disable_unprepare(imx->clk_per); > - imx->enabled = 0; > } > > static struct pwm_ops imx_pwm_ops = { > -- > 1.7.10.4 > > > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
