> -----Original Message----- > From: Guenter Roeck [mailto:[email protected]] > Sent: 18 April 2013 05:14 > To: Opensource [Anthony Olech] > Cc: Jean Delvare; Mark Brown; Randy Dunlap; [email protected]; > LKML; David Dajun Chen > Subject: Re: [NEW DRIVER V5 6/7] drivers/hwmon: DA9058 HWMON driver > [...] > > + if (cell == NULL) { > > + ret = -ENODEV; > > + goto exit; > > Just return -ENODEV is good enough here. See CodingStyle, chapter 7. > [...] > > +exit: > > + return ret; > > +} [...]
Hi Guenter, I have read CodingStyle, chapter 7 and it seems to encourage a single exit point from functions. During development there was some logging done at the (single) exit point but that has been stripped out for submission. Whilst I can duplicate the logging and do an immediate 'return' at all those points, I am hesitant to do so when chapter 7 of the CodingStyle appears to say to use a single exit point. In addition I had thought that a single exit point from functions was a good thing. Tony Olech -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
