Copy Sascha. Shawn
On Thu, Apr 18, 2013 at 11:23:52AM +0200, Maxime Ripard wrote: > The current code always registers as a 32 bits display, and uses the > hardware to drop the MSB of each color to abjust to the interface width > used by the panel. > > This results on 18 bits (and probably 16 bits display as well) in colors > being displayed poorly, because the MSB are obviously the most important > bits for each color definition. > > The default controller behaviour when using an interface width smaller > than the color depth is to drop the LSBs of each color, which makes more > sense because you lose the least important part of the color definition. > > So, to fix the colors display, just get back to the default controller > behaviour. > > Signed-off-by: Maxime Ripard <[email protected]> > --- > drivers/video/mxsfb.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c > index 755556c..2cfaf8b 100644 > --- a/drivers/video/mxsfb.c > +++ b/drivers/video/mxsfb.c > @@ -424,11 +424,6 @@ static int mxsfb_set_par(struct fb_info *fb_info) > return -EINVAL; > case STMLCDIF_16BIT: > case STMLCDIF_18BIT: > - /* 24 bit to 18 bit mapping */ > - ctrl |= CTRL_DF24; /* ignore the upper 2 bits in > - * each colour component > - */ > - break; > case STMLCDIF_24BIT: > /* real 24 bit */ > break; > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
