2013/04/18 22:42, Johannes Weiner wrote:
On Thu, Apr 18, 2013 at 05:36:12PM +0900, Yasuaki Ishimatsu wrote:
@@ -151,6 +162,39 @@ __initcall(ioresources_init);

  #endif /* CONFIG_PROC_FS */

+static void free_resource(struct resource *res)
+{
+       if (!res)
+               return;
+
+       if (PageSlab(virt_to_head_page(res))) {
+               spin_lock(&bootmem_resource_lock);
+               res->sibling = bootmem_resource.sibling;
+               bootmem_resource.sibling = res;
+               spin_unlock(&bootmem_resource_lock);
+       } else {
+               kfree(res);
+       }


The branch is mixed up, you are collecting slab objects in
bootmem_resource and kfreeing bootmem.

Ah. I'm wrong. I'll update soon.

Thanks,
Yasuaki Ishimatsu


+static struct resource *get_resource(gfp_t flags)
+{
+       struct resource *res = NULL;
+
+       spin_lock(&bootmem_resource_lock);
+       if (bootmem_resource.sibling) {
+               res = bootmem_resource.sibling;
+               bootmem_resource.sibling = res->sibling;
+               memset(res, 0, sizeof(struct resource));
+       }
+       spin_unlock(&bootmem_resource_lock);
+
+       if (!res)
+               res = kzalloc(sizeof(struct resource), flags);
+
+       return res;
+}
+
  /* Return the conflict entry if you can't request it */
  static struct resource * __request_resource(struct resource *root, struct 
resource *new)
  {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to