On Thu, Apr 18, 2013 at 11:11:50AM +0100, Lee Jones wrote: > The current implementation of the DMA40's local MAX() macro evaluates > its arguments more times than is necessary. This patch strips it > optimises it to only evaluate what's appropriate. > > Cc: Vinod Koul <[email protected]> > Cc: Dan Williams <[email protected]> > Cc: Per Forlin <[email protected]> > Cc: Rabin Vincent <[email protected]> > Reported-by: Harvey Harrison <[email protected]> > Signed-off-by: Lee Jones <[email protected]> > --- > drivers/dma/ste_dma40.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c > index b21a8a3..7b451b2 100644 > --- a/drivers/dma/ste_dma40.c > +++ b/drivers/dma/ste_dma40.c > @@ -53,7 +53,7 @@ > #define D40_ALLOC_PHY BIT(30) > #define D40_ALLOC_LOG_FREE BIT(0) > > -#define MAX(a, b) (((a) < (b)) ? (b) : (a)) > +#define MAX(a, b) ((a > b) ? a : b) Am not a big fan of own redefines, can you use kernel max() macro instead
-- ~Vinod > > #define D40_IS_SRC(dir) ((dir == STEDMA40_PERIPH_TO_MEM) ? true : false) > #define D40_IS_DST(dir) (((dir == STEDMA40_MEM_TO_PERIPH) || \ > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
