On Wed, Apr 24, 2013 at 10:19:27AM +0800, Wei Yongjun wrote: > From: Wei Yongjun <[email protected]> > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun <[email protected]> > --- > drivers/gpu/host1x/drm/gr2d.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/host1x/drm/gr2d.c b/drivers/gpu/host1x/drm/gr2d.c > index 6a45ae0..146cd64 100644 > --- a/drivers/gpu/host1x/drm/gr2d.c > +++ b/drivers/gpu/host1x/drm/gr2d.c > @@ -135,8 +135,10 @@ static int gr2d_submit(struct host1x_drm_context > *context, > goto fail; > > bo = host1x_bo_lookup(drm, file, cmdbuf.handle); > - if (!bo) > + if (!bo) { > + err = -EINVAL;
I think in this case a better error code would be -ENOENT. Other than that this patch looks good. Thierry
pgpaF9xmMaPw_.pgp
Description: PGP signature
