On Mon, 22 Apr 2013, Russell King - ARM Linux wrote: > On Mon, Apr 22, 2013 at 11:37:15AM +0100, Lee Jones wrote: > > On Mon, 22 Apr 2013, Vinod Koul wrote: > > > > > On Mon, Apr 22, 2013 at 11:14:55AM +0100, Lee Jones wrote: > > > > On Mon, 22 Apr 2013, Vinod Koul wrote: > > > > > > > > > On Thu, Apr 18, 2013 at 11:12:03AM +0100, Lee Jones wrote: > > > > > > + dev_info(&pdev->dev, "hardware revision: %d @ 0x%x with " > > > > > > + "%d physical channels and %d logical channels\n", > > > > > > + rev, res->start, num_phy_chans, num_log_chans); > > > > > Splitting log messages across lines is bad idea and sacrifces > > > > > readablity... also > > > > > wasnt splitting logging to multiple lines emit checkpatch warn > > Yes, but for a different reason... > > > > > You also get a check-patch error if your lines are over 80 chars. > > > No, you get a warn > > > > You only get a warning for this too: > > > > WARNING: quoted string split across lines > > #33: FILE: drivers/dma/ste_dma40.c:3204: > > + dev_info(&pdev->dev, "hardware revision: %d @ 0x%x with " > > + "%d physical channels and %d logical channels\n", > > From coding style: "However, never break user-visible strings such as > printk messages, because that breaks the ability to grep for them." > > You can argue that you wouldn't grep for the above string - but consider > if you grepped for "hardware revision.*channels" to try and find the > above message, which would be a reasonable thing to try if you got lots > of hits on just "hardware revision".
Okay, this I understand. I'll fixup. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/