On Mon, 22 Apr 2013, Lee Jones wrote: > > > void d40_phy_cfg(struct stedma40_chan_cfg *cfg, > > > u32 *src_cfg, u32 *dst_cfg, bool is_log) > > > @@ -107,11 +113,6 @@ void d40_phy_cfg(struct stedma40_chan_cfg *cfg, > > > src |= 1 << D40_SREG_CFG_PRI_POS; > > > dst |= 1 << D40_SREG_CFG_PRI_POS; > > shouldnt these be converted to BIT() macro and in gim_unmask above? > > Driver needs to be consistent in doing things > > Absolutely they do. I haven't converted ste_dma40_ll.c to BIT yet > though. I have this on my TODO and it will happen in the next > patch-set.
Vinod, are you happy to Ack this on the proviso that I follow it up with a subsequent patch converting the ste_dma40_ll driver to BIT()? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
