On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones <[email protected]> wrote:
> All configuration left in d40_phy_cfg() is runtime configurable and > there is already a call into it from d40_runtime_config(), so let's > rely on that. > > Cc: Vinod Koul <[email protected]> > Cc: Dan Williams <[email protected]> > Cc: Per Forlin <[email protected]> > Cc: Rabin Vincent <[email protected]> > Signed-off-by: Lee Jones <[email protected]> NAK. Have you really tested this with memcpy()? The runtime config function is *not* called when doing memcpy DMA, still the channels used for memcpy need to be configured obviously. Now you're assuming that every time anyone is using a DMA channel they will first allocate it, then call the runtime config. This is not true. Runtime config is only used when doing dev->mem and mem->dev DMA. You may just as well compile in the test program that is there right in the kernel and run it ... it's good! (DMA Test Client in menuconfig under drivers/dma engine support...) There was this other patch not taking the memcpy channels into the array that I think will also cause a crash when doing memcpy so I'm pretty sure you're not testing this. When I test these patches I will run it, and just report that memcpy doesn't work if it doesn't and then you'll have to figure it out anyway, so enjoy... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
