On Thu, Apr 25, 2013 at 3:00 PM, H. Peter Anvin <[email protected]> wrote: > On 04/25/2013 02:54 PM, Kees Cook wrote: >> Since has_eflag() and has_fpu() are 32-bit only, short-circuit the >> routines on 64-bit when they are built without -m32. This also refactors >> the calls to cpuid to make them PIC-safe on 32-bit. > > These functions can trivially be made 32- and 64-bit agnostic by > changing "u32" to "unsigned long" and drop the -l suffixes in the > assembly code.
Ah, good call. I found what was stopping me earlier. The u32 argument needed to be switched to unsigned long too. Duh. :) Thanks! -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
