Hi Dmitry, Thanks for your review and suggestion!
於 一，2013-04-22 於 21:04 -0700，Dmitry Torokhov 提到： > On Mon, Apr 22, 2013 at 08:39:14PM +0800, Chun-Yi Lee wrote: > > From: Lee, Chun-Yi <j...@suse.com> > > > > After Andrzej's testing, we found the acpi backlight methods broken on Acer > > Aspire 5750G but the i915 backlight control works when we set to vendor > > mode. > > And, we still want to keep the acpi/video driver for transfer acpi event to > > key > > event but not unregister whole acpi/video driver. > > > > This patch introduced a new capability flag is ACER_CAP_KEEP_VIDEO_KEY, it > > indicates the machine works fine with acpi/video driver for key event but > > want > > to unregister the backlight interface of acpi/video. > > > > Reference: bko#35622 > > https://bugzilla.kernel.org/show_bug.cgi?id=35622 > > > > Tested-by: Andrzej Krentosz <endr...@gmail.com> > > Cc: Carlos Corbacho <car...@strangeworlds.co.uk> > > Cc: Matthew Garrett <m...@redhat.com> > > Cc: Dmitry Torokhov <d...@mail.ru> > > Cc: Corentin Chary <corenti...@iksaif.net> > > Cc: Rafael J. Wysocki <r...@sisk.pl> > > Cc: Aaron Lu <aaron...@intel.com> > > Cc: Thomas Renninger <tr...@suse.de> > > Signed-off-by: Lee, Chun-Yi <j...@suse.com> > > --- > > drivers/platform/x86/acer-wmi.c | 20 ++++++++++++++++++++ > > 1 files changed, 20 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/platform/x86/acer-wmi.c > > b/drivers/platform/x86/acer-wmi.c > > index c9076bd..2a02409 100644 > > --- a/drivers/platform/x86/acer-wmi.c > > +++ b/drivers/platform/x86/acer-wmi.c > > @@ -207,6 +207,7 @@ struct hotkey_function_type_aa { > > #define ACER_CAP_BRIGHTNESS (1<<3) > > #define ACER_CAP_THREEG (1<<4) > > #define ACER_CAP_ACCEL (1<<5) > > +#define ACER_CAP_KEEP_VIDEO_KEY (1<<6) > > #define ACER_CAP_ANY (0xFFFFFFFF) > > > > /* > > @@ -539,6 +540,15 @@ static int video_set_backlight_video_vendor(const > > struct dmi_system_id *d) > > return 0; > > } > > > > +static int video_set_backlight_video_vendor_keep_acpi_video( > > + const struct dmi_system_id *d) > > +{ > > + video_set_backlight_video_vendor(d); > > + interface->capability |= ACER_CAP_KEEP_VIDEO_KEY; > > + pr_info("Keep acpi video driver for emit keycode against backlight > > change\n"); > > Huh? > > "Keeping acpi video driver active to emit backlight brightness change > key events"? > > Thanks. > Yes, this statement is more fluent, I will put to v2 patch. Thanks a lot! Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
