Hi,
On 16:07 Wed 01 May , Lars-Peter Clausen wrote:
> On 05/01/2013 12:21 AM, Oskar Andero wrote:
> > This adds support for Microchip's 12 bit AD converters MCP3204 and
> > MCP3208. These chips communicates over SPI and supports single-ended
> > and pseudo-differential configurations.
> >
> > Cc: Jonathan Cameron <ji...@cam.ac.uk>
> > Cc: Lars-Peter Clausen <l...@metafoo.de>
> > Signed-off-by: Oskar Andero <oskar.and...@gmail.com>
>
> Hi,
>
> Looks very good in general. A few minor things, mostly related to the
> regulator
> handling and a couple of nitpicks inline.
Thanks for reviewing! I will prepare version 2 shortly.
> > +
> > + ret = regulator_enable(adc->reg);
> > + if (ret < 0)
> > + goto reg_free;
> > + } else {
> > + adc->ref_mv = pdata->ref_mv;
>
> I'd like to see this fallback path go away. For supplies with a const voltage
> the fixed-voltage-regulator can be used.
>
Ok. I added this since the voltage I use for reference is behind a
level-shifter,
meaning there is actually no regulator on the board providing that exact
voltage level. Not sure what you mean with "the fixed-voltage-regulator", but
maybe that is what I am looking for in my case?
Thanks!
-Oskar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
