On Mon, Feb 04, 2013 at 01:32:57PM +0100, Jiri Olsa wrote: > From: "[email protected]" <[email protected]> > > It's possible some of the counters in the group could be > disabled when sampling member of the event group is reading > the rest via PERF_SAMPLE_READ sample type processing. Disabled > counters could then produce wrong numbers. > > Fixing that by reading only enabled counters for PERF_SAMPLE_READ > sample type processing. > > Signed-off-by: Jiri Olsa <[email protected]> > Cc: Arnaldo Carvalho de Melo <[email protected]>
I had to like re-read our previous thread on this; which I think says that the Changelog isn't perfect. However: Acked-by: Peter Zijlstra <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Paul Mackerras <[email protected]> > Cc: Corey Ashford <[email protected]> > Cc: Frederic Weisbecker <[email protected]> > Cc: Namhyung Kim <[email protected]> > --- > kernel/events/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 4081261..e2ea1b9 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -4018,7 +4018,8 @@ static void perf_output_read_group(struct > perf_output_handle *handle, > list_for_each_entry(sub, &leader->sibling_list, group_entry) { > n = 0; > > - if (sub != event) > + if ((sub != event) && > + (sub->state == PERF_EVENT_STATE_ACTIVE)) > sub->pmu->read(sub); > > values[n++] = perf_event_count(sub); > -- > 1.7.11.7 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
