On Wed, May 8, 2013 at 3:29 PM, Lee Jones <[email protected]> wrote:
> When booting with Device Tree enabled the MFD core uses each device's > compatible string to find and allocate its associated of_node pointer, > which in turn is passed to the driver via the platform_device struct. > Without it, the driver won't be able to interrogate the Device Tree or > locate suitable regulators and will most likely fail to probe. > > Cc: Samuel Ortiz <[email protected]> > Signed-off-by: Lee Jones <[email protected]> Can you explain what regression this is causing since the GPADC driver (drivers/mfd/ab8500-gpadc.c) does not support device tree probing and does not have an .of_match_table defined in it's driver struct? I mean, what could possibly match that compatible string? The .name field will take care of naming the device does it not? For non-emergency merging though: Acked-by: Linus Walleij <[email protected]> Since it matches the example in Documentation/devicetree/bindings/mfd/ab8500.txt But for this to make sense the AB8500 ADC driver needs to be augmented for DT probing and preferrably also moved to drivers/adc and made to utilize that subsystem. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
