Hi Prabhakar, On Wednesday 15 May 2013 10:48:05 Prabhakar Lad wrote: > On Tue, May 14, 2013 at 9:04 PM, Laurent Pinchart wrote: > > On Tuesday 14 May 2013 16:15:34 Lad Prabhakar wrote: > >> From: Lad, Prabhakar <[email protected]> > >> > >> add OF support for the tvp7002 driver. > >> > >> Signed-off-by: Lad, Prabhakar <[email protected]> > >> Cc: Hans Verkuil <[email protected]> > >> Cc: Laurent Pinchart <[email protected]> > >> Cc: Mauro Carvalho Chehab <[email protected]> > >> Cc: Guennadi Liakhovetski <[email protected]> > >> Cc: Sylwester Nawrocki <[email protected]> > >> Cc: Sakari Ailus <[email protected]> > >> Cc: Grant Likely <[email protected]> > >> Cc: Rob Herring <[email protected]> > >> Cc: Rob Landley <[email protected]> > >> Cc: [email protected] > >> Cc: [email protected] > >> Cc: [email protected] > >> Cc: [email protected] > >> --- > >> > >> .../devicetree/bindings/media/i2c/tvp7002.txt | 42 +++++++++++++ > >> drivers/media/i2c/tvp7002.c | 64 ++++++++++++-- > >> 2 files changed, 99 insertions(+), 7 deletions(-) > >> create mode 100644 > >> Documentation/devicetree/bindings/media/i2c/tvp7002.txt > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/tvp7002.txt > >> b/Documentation/devicetree/bindings/media/i2c/tvp7002.txt new file mode > >> 100644 > >> index 0000000..1ebd8b1 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/i2c/tvp7002.txt > >> @@ -0,0 +1,42 @@ > >> +* Texas Instruments TV7002 video decoder > >> + > >> +The TVP7002 device supports digitizing of video and graphics signal in > >> +RGB and +YPbPr color space. > >> + > >> +Required Properties : > >> +- compatible : Must be "ti,tvp7002" > >> + > >> +- hsync-active: HSYNC Polarity configuration for endpoint. > >> + > >> +- vsync-active: VSYNC Polarity configuration for endpoint. > >> + > >> +- pclk-sample: Clock polarity of the endpoint. > >> + > >> +- ti,tvp7002-fid-polarity: Active-high Field ID polarity of the > >> endpoint. > >> + > >> +- ti,tvp7002-sog-polarity: Sync on Green output polarity of the > >> endpoint. > > > > Would it make sense to define field-active and sog-active properties in > > the V4L2 bindings instead of having per-chip properties ? > > yes you are right these properties need to be in the device node rather than > the port node. I'll send alone this patch of the series as v2 fixing the > above.
That wasn't my point. What I'm wondering is whether ti,tvp7002-fid-polarity shouldn't be named field-active and specified in Documentation/devicetree/bindings/media/video-interfaces.txt (same for ti,tvp7002-sog-polarity). -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
