On Fri, May 17, 2013 at 8:58 PM, Joe Perches <j...@perches.com> wrote:
> On Fri, 2013-05-17 at 20:50 +0300, Leon Romanovsky wrote:
>> On Fri, May 17, 2013 at 1:13 AM, Samuel Ortiz <sa...@linux.intel.com> wrote:
>> > On Wed, May 15, 2013 at 01:53:56PM +0300, Leon Romanovsky wrote:
>> >> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> []
>> >> @@ -121,7 +121,7 @@ static struct sec_platform_data
>> >> *sec_pmic_i2c_parse_dt_pdata(
> []
>> >> - pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL);
>> >> + pd = devm_kzalloc(dev, sizeof(struct sec_platform_data),
>> >> GFP_KERNEL);
>> > How is that fixing anything ?
>> Technically you are right, this fix brings code to be align to common
>> code convention and allows to automatic tools correctly parse it.
>
> Not really.
> Common coding convention is actually the original code.
>
> from: Documentation/CodingStyle:
>
> Chapter 14: Allocating memory
> []
> The preferred form for passing a size of a struct is the following:
>
> p = kmalloc(sizeof(*p), ...);
>
>
Thanks Joe, it is good to know, but from my simple grep, most
developers doesn't follow with this guide:
leon@tux ~/dev/kernel/linux-staging $ grep -r "sizeof(struct" * | wc -l
25865
leon@tux ~/dev/kernel/linux-staging $ grep -r "sizeof(\*" * | wc -l
14568
--
Leon Romanovsky | Independent Linux Consultant
www.leon.nu | l...@leon.nu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
