On Tue, 2013-04-23 at 16:31 +0300, Andy Shevchenko wrote: > We have mac_pton() helper to parse MAC addresses. > > Signed-off-by: Andy Shevchenko <[email protected]> > --- > drivers/misc/pch_phub.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c > index 931e635..8b4d4fb 100644 > --- a/drivers/misc/pch_phub.c > +++ b/drivers/misc/pch_phub.c > @@ -633,17 +633,13 @@ static ssize_t show_pch_mac(struct device *dev, struct > device_attribute *attr, > static ssize_t store_pch_mac(struct device *dev, struct device_attribute > *attr, > const char *buf, size_t count) > { > - u8 mac[6]; > + u8 mac[ETH_ALEN]; > ssize_t rom_size; > struct pch_phub_reg *chip = dev_get_drvdata(dev); > > - if (count != 18) > + if (!mac_pton(buf, mac)) > return -EINVAL; > > - sscanf(buf, "%02x:%02x:%02x:%02x:%02x:%02x", > - (u32 *)&mac[0], (u32 *)&mac[1], (u32 *)&mac[2], (u32 *)&mac[3], > - (u32 *)&mac[4], (u32 *)&mac[5]); > - > chip->pch_phub_extrom_base_address = pci_map_rom(chip->pdev, &rom_size); > if (!chip->pch_phub_extrom_base_address) > return -ENOMEM;
Arnd, do you have any comment on this one? -- Andy Shevchenko <[email protected]> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
