On Tue, 28 May 2013, tip-bot for David Cohen wrote: > Commit-ID: 8c956b1b935ec98decb470a6abff8c1f8b28e9f0 > Gitweb: http://git.kernel.org/tip/8c956b1b935ec98decb470a6abff8c1f8b28e9f0 > Author: David Cohen <[email protected]> > AuthorDate: Tue, 30 Apr 2013 16:20:15 -0700 > Committer: Ingo Molnar <[email protected]> > CommitDate: Tue, 28 May 2013 12:01:29 +0200 > > irq/x86/io_apic: Fix number of pre-allocated irqs > > arch_probe_nr_irqs() has a typo when returning number of > preallocated irqs. Instead of returning the calculated value, it > returns a constant number NR_IRQ_LEGACY.
That's not a typo. That's on purpose. We don't want to allocate a gazillion of interrupt descriptors for nothing. The only ones which must be pre-allocated are the legacy ones. > This patch makes sure the calculated value is returned intead. And therefor defeats the whole purpose of sparse irqs. I'll zap that commit. > Signed-off-by: David Cohen <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: [email protected] > Link: > http://lkml.kernel.org/r/[email protected] > Signed-off-by: Ingo Molnar <[email protected]> > --- > arch/x86/kernel/apic/io_apic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c > index 9ed796c..7ef2bd9 100644 > --- a/arch/x86/kernel/apic/io_apic.c > +++ b/arch/x86/kernel/apic/io_apic.c > @@ -3437,7 +3437,7 @@ int __init arch_probe_nr_irqs(void) > if (nr < nr_irqs) > nr_irqs = nr; > > - return NR_IRQS_LEGACY; > + return nr; > } > > int io_apic_set_pci_routing(struct device *dev, int irq, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
