Commit-ID:  4d23322a0b8d0f40819dc02ea15a732a78b0a1c0
Gitweb:     http://git.kernel.org/tip/4d23322a0b8d0f40819dc02ea15a732a78b0a1c0
Author:     Jiri Olsa <[email protected]>
AuthorDate: Thu, 13 Dec 2012 14:09:00 +0100
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 28 May 2013 16:24:02 +0300

perf hists: Rename hist_entry__add_pair arguments

The current logic is to attach pair to the leader hist_entry.

Arguments of hist_entry__add_pair function were placed the other way
round.. driving me crazy.

I.e. list_add_tail expects (new_node, head).

Signed-off-by: Jiri Olsa <[email protected]>
Cc: Corey Ashford <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: 
http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/util/sort.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index 51f1b5a..45ac84c 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -117,10 +117,10 @@ static inline struct hist_entry 
*hist_entry__next_pair(struct hist_entry *he)
        return NULL;
 }
 
-static inline void hist_entry__add_pair(struct hist_entry *he,
-                                       struct hist_entry *pair)
+static inline void hist_entry__add_pair(struct hist_entry *pair,
+                                       struct hist_entry *he)
 {
-       list_add_tail(&he->pairs.head, &pair->pairs.node);
+       list_add_tail(&pair->pairs.node, &he->pairs.head);
 }
 
 enum sort_mode {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to