On Monday 03 June 2013 14:42:33 Lee Jones wrote:
> @@ -650,6 +650,9 @@
> <&dma 13 0 0x0>; /* Logical - MemToDev */
> dma-names = "rx", "tx";
>
> + clocks = <&clk 83>, <&clk 40>;
> + clock-names = "uart0", "apb_pclk";
> +
> status = "disabled";
> };
>
> @@ -662,6 +665,9 @@
> <&dma 12 0 0x0>; /* Logical - MemToDev */
> dma-names = "rx", "tx";
>
> + clocks = <&clk 84>, <&clk 41>;
> + clock-names = "uart1", "apb_pclk";
> +
> status = "disabled";
> };
>
This seems wrong: why would one of them have a clock named "uart0"
and the other one call it "uart1"? The clock name should be defined
in the binding and specific to the driver using it, not a string that
indicates where it is connected to.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
