3.9-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Wei Liu <wei.l...@citrix.com>

commit ac69c26e7accb04ae2cb9ab0872068983a42b3c8 upstream.

Tracking down from the caller, first_idx is always equal to vif->tx.req_cons.
Remove it to avoid confusion.

Suggested-by: Jan Beulich <jbeul...@suse.com>
Signed-off-by: Wei Liu <wei.l...@citrix.com>
Acked-by: Ian Campbell <ian.campb...@citrix.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 drivers/net/xen-netback/netback.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -928,7 +928,6 @@ static void netbk_fatal_tx_err(struct xe
 
 static int netbk_count_requests(struct xenvif *vif,
                                struct xen_netif_tx_request *first,
-                               RING_IDX first_idx,
                                struct xen_netif_tx_request *txp,
                                int work_to_do)
 {
@@ -1005,7 +1004,7 @@ static int netbk_count_requests(struct x
        } while ((txp++)->flags & XEN_NETTXF_more_data);
 
        if (drop_err) {
-               netbk_tx_err(vif, first, first_idx + slots);
+               netbk_tx_err(vif, first, cons + slots);
                return drop_err;
        }
 
@@ -1475,8 +1474,7 @@ static unsigned xen_netbk_tx_build_gops(
                                continue;
                }
 
-               ret = netbk_count_requests(vif, &txreq, idx,
-                                          txfrags, work_to_do);
+               ret = netbk_count_requests(vif, &txreq, txfrags, work_to_do);
                if (unlikely(ret < 0))
                        continue;
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to