On Tue, 2013-06-04 at 19:22 +0200, Willy Tarreau wrote: > 2.6.32-longterm review patch. If anyone has any objections, please let me > know. > > ------------------ > properly > > From: Sean Connor <sconnor...@allyinics.org> > > commit 69a4cfdd444d1fe5c24d29b3a063964ac165d2cd upstream. > > Set card->private_data in snd_ice1712_create for fixing NULL > dereference in snd_ice1712_remove().
This bug appears to have been introduced in Linux 3.8 and doesn't need
fixing in 2.6.32.
Ben.
> Signed-off-by: Sean Connor <sconnor...@allyinics.org>
> Signed-off-by: Takashi Iwai <ti...@suse.de>
> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Signed-off-by: Willy Tarreau <w...@1wt.eu>
> ---
> sound/pci/ice1712/ice1712.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
> index d74033a..95496ae 100644
> --- a/sound/pci/ice1712/ice1712.c
> +++ b/sound/pci/ice1712/ice1712.c
> @@ -2574,6 +2574,8 @@ static int __devinit snd_ice1712_create(struct snd_card
> *card,
> snd_ice1712_proc_init(ice);
> synchronize_irq(pci->irq);
>
> + card->private_data = ice;
> +
> err = pci_request_regions(pci, "ICE1712");
> if (err < 0) {
> kfree(ice);
--
Ben Hutchings
Theory and practice are closer in theory than in practice.
- John Levine, moderator of comp.compilers
signature.asc
Description: This is a digitally signed message part
