On Sat, Jun 8, 2013 at 5:21 PM, Russell King - ARM Linux <[email protected]> wrote: > On Sat, Jun 08, 2013 at 09:57:17AM +0100, Jonathan Cameron wrote: >> At least one Arm subarch (pxa) does no provide an implementation of this >> function. As far as I can see there is no way for a driver wishing to use >> it to detect it's absence. This is marked in clk.h as being optional >> for 'Machine Class support'. Obvious solutions to this are: >> >> 1) It is effectively only usable by platform specific drivers as no >> more generic driver can know it is available. Perhaps even a stub that >> returns an appropriate error would be acceptable. >> >> 2) It is not as optional as the header implies and should always be >> implemented >> if the rest of the clk framework is. >> >> 3) There should be some means of detecting its absense so that drivers can >> be dependant on its presene. >> >> Which is the correct one? > > The right answer is (2) now that we have things like the clk framework and > soo many users.
Yes, we need to fix it. I'll handle it. Regards Haojian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
