Dave Hansen wrote:
> On 06/07/2013 08:10 AM, Kirill A. Shutemov wrote:
> > + /*
> > + * When we add a huge page to page cache we take only reference to head
> > + * page, but on split we need to take addition reference to all tail
> > + * pages since they are still in page cache after splitting.
> > + */
> > + init_tail_refcount = PageAnon(page) ? 0 : 1;
>
> What's the "init" for in the name?
initial_tail_refcount?
> In add_to_page_cache_locked() in patch 12/39, you do
> > + spin_lock_irq(&mapping->tree_lock);
> > + for (i = 0; i < nr; i++) {
> > + page_cache_get(page + i);
>
> That looks to me to be taking references to the tail pages. What gives? :)
The point is to drop this from add_to_page_cache_locked() and make distribution
on split.
--
Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
