On 11/06/13 21:13, Linus Walleij wrote: > On Tue, Jun 11, 2013 at 4:05 PM, Srinivas KANDAGATLA > <[email protected]> wrote: > >> Doing this is not adding any value to the driver, because >> 1. Currently the driver only support DT boot paths, in my previous RFC >> patches, Arnd suggested to get rid of the header as all platforms are DT >> now. > > In that case why do you have the separate global_timer_init() > at all? Just move that code into global_timer_of_register() and > also remove the #ifdef around CONFIG_OF and make the driver > depend on CONFIG_OF in Kconfig. > > After this you realize that all that business with > clk_register_clkdev() / clk_get_sys() is just pure surplus > baggade, you just use of_clk_get() and that's it.
It makes sense to move all the code into global_timer_of_register(). This will also get rid of un-used code. I will do this in the next spin. Thanks, srini > > Yours, > Linus Walleij > _______________________________________________ > devicetree-discuss mailing list > [email protected] > https://lists.ozlabs.org/listinfo/devicetree-discuss > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
