Ben Hutchings <[email protected]> writes: > 3.2.47-rc1 review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Theodore Ts'o <[email protected]> > > commit 721e3eba21e43532e438652dd8f1fcdfce3187e7 upstream.
I'm also queuing this commit as it looks like 3.5 is also missing it. Cheers, -- Luis > > Commit c278531d39 added a warning when ext4_flush_unwritten_io() is > called without i_mutex being taken. It had previously not been taken > during orphan cleanup since races weren't possible at that point in > the mount process, but as a result of this c278531d39, we will now see > a kernel WARN_ON in this case. Take the i_mutex in > ext4_orphan_cleanup() to suppress this warning. > > Reported-by: Alexander Beregalov <[email protected]> > Signed-off-by: "Theodore Ts'o" <[email protected]> > Reviewed-by: Zheng Liu <[email protected]> > Signed-off-by: Ben Hutchings <[email protected]> > --- > fs/ext4/super.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -2260,7 +2260,9 @@ static void ext4_orphan_cleanup(struct s > __func__, inode->i_ino, inode->i_size); > jbd_debug(2, "truncating inode %lu to %lld bytes\n", > inode->i_ino, inode->i_size); > + mutex_lock(&inode->i_mutex); > ext4_truncate(inode); > + mutex_unlock(&inode->i_mutex); > nr_truncates++; > } else { > ext4_msg(sb, KERN_DEBUG, > > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
