On Mon, Jun 17, 2013 at 04:20:16PM +0200, Lorenz Haspel wrote:
> fixed checkpatch error:
> trailing statements that should be on next line
>
> Signed-off-by: Michael Banken <[email protected]>
> Signed-off-by: Lorenz Haspel <[email protected]>
> ---
> drivers/staging/silicom/bpctl_mod.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/silicom/bpctl_mod.c
> b/drivers/staging/silicom/bpctl_mod.c
> index 78570dd..85aa900 100644
> --- a/drivers/staging/silicom/bpctl_mod.c
> +++ b/drivers/staging/silicom/bpctl_mod.c
> @@ -165,7 +165,9 @@ static int bp_device_event(struct notifier_block *unused,
> memcpy(&cbuf, drvinfo.bus_info, 32);
> buf = &cbuf[0];
>
> - while (*buf++ != ':') ;
> + while (*buf != ':')
> + buf++;
> + buf++;
No. This is more complicated than the original. While loops like
this are idiomatic in C. The way to fix this is just to do:
while (*buf++ != ':')
;
Same for the rest, just move the semi-colon down in every case.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
