On Tue, 2013-06-25 at 19:10 +0900, Masami Hiramatsu wrote: > (2013/06/25 17:15), zhangwei(Jovi) wrote: > > There have no good reason to call free_trace_probe > > every time when unregister_trace_probe return 0. > > > > Move free_trace_probe into unregister_trace_probe, > > make code simpler. > > Sorry, nack. For the symmetrical coding reason, I don't like > involving "free" and "alloc" into "unregister"/"register" > functions. I think those should be just another actions.
I totally agree with Masami here. Please do not add "side effects" to the unregister function. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
