----- Original Message -----
> From: "Tony Luck" <[email protected]>
> To: "Lenny Szubowicz" <[email protected]>
> Cc: "Anton Vorontsov" <[email protected]>, "Matt Fleming"
> <[email protected]>, "Linux Kernel Mailing List"
> <[email protected]>, "n hamaguchi" <[email protected]>,
> "Don Zickus" <[email protected]>
> Sent: Friday, June 28, 2013 4:44:51 PM
> Subject: Re: [PATCH 2/3] acpi: Eliminate console msg if pstore.backend
> excludes ERST
>
> On Fri, Jun 28, 2013 at 1:14 PM, Lenny Szubowicz <[email protected]> wrote:
>
> > - if (pstore_register(&erst_info)) {
> > - pr_info(ERST_PFX "Could not register with
> > persistent store\n");
> > + rc = pstore_register(&erst_info);
> > + if (rc) {
> > + if (rc != -EPERM)
> > + pr_info(ERST_PFX
> > + "Could not register with persistent
> > store\n");
> > + erst_info.buf = NULL;
> > + erst_info.bufsize = 0;
>
> Mismatch between part 1 and part 2 here ... we return -EINVAL if
> our name doesn't match the desired backend ... but you only suppress
> the "Could not register" message for -EPERM
>
> Or am I confused while just looking at patch fragments?
>
> -Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Yes, you are absolutely correct. My [PATCH 1/3] is not what I intended. Thanks!
-Lenny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
