On Mon, Jun 24, 2013 at 04:50:58PM +0530, Yadwinder Singh Brar wrote:
> +static void s2mps11_pmic_parse_dt(struct of_regulator_match *rdata,
> + struct s2mps11_info *s2mps11)
> +{
> + if (!of_find_property(rdata[S2MPS11_BUCK2].of_node,
> + "regulator-ramp-disable", NULL))
> + s2mps11->buck2_ramp = true;This property should be specific to this binding rather than named as a generic regulator property. It's also a bit odd that setting a property called "regulator-ramp-disable" causes the flag buckN_ramp to be set to true - if the ramp is being disabled I'd expect a flag with that name to be false not true. Seems something isn't named right.
signature.asc
Description: Digital signature
