I only just noticed the existence of CONFIG_COMPILE_TEST (now in
mainline as of merge fc76a258d41 ("Merge tag 'driver-core-3.11-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core")
I like this; it parallels a discussion I had with Andrew a while ago:
https://lkml.org/lkml/2013/3/7/456
I wish I had seen it earlier, as at the moment it only has three use case
instances/examples. I have at my fingertips three more that were cases
where I wanted to add a real world dependency that limited the option to
those who it was useful to, but the rebuttals I got were that the
maintainers liked the compile coverage (see links in each commmit.)
It might be nice to have a few more examples showing proper dependency
usage of COMPILE_TEST, if the opportunity arises. In the same vein as
having more available examples, we can teach checkpatch to spot when
people incorrectly try and use this in C (as has already happened.)
It might help avoid doing that education campaign via lkml lessons.
That said, I realize we are well into week one of the merge window,
so if need be, it isn't a problem for me to hang on to them for 3.12.
Thanks,
Paul.
---
[I made a temporary bad commit to test the new checkpatch rule. I
[also build tested for OMAP2 with USB options on & COMPILE_TEST off]
Cc: Andy Whitcroft <[email protected]>
Cc: Anton Vorontsov <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: David Woodhouse <[email protected]>
Cc: Felipe Balbi <[email protected]>
Cc: Florian Tobias Schandinat <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Jiri Slaby <[email protected]>
Cc: Joe Perches <[email protected]>
Cc: Kishon Vijay Abraham I <[email protected]>
Cc: Moiz Sonasath <[email protected]>
Paul Gortmaker (4):
usb: limit OMAP related USB options to OMAP2PLUS platforms
power: make goldfish_battery depend on GOLDFISH || COMPILE_TEST
video: make goldfish video depend on GOLDFISH || COMPILE_TEST
checkpatch: only allow COMPILE_TEST in Kconfig dependency lines
drivers/power/Kconfig | 2 +-
drivers/usb/phy/Kconfig | 2 ++
drivers/video/Kconfig | 2 +-
scripts/checkpatch.pl | 6 ++++++
4 files changed, 10 insertions(+), 2 deletions(-)
--
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
