On 06/07/13 06:39, Dan Carpenter wrote: > We're freeing the list iterator so we can't move to the next entry. > Since there is only one matching mport_id, we can just break after > finding it. > > Signed-off-by: Dan Carpenter <[email protected]> > --- > v2: cleaner fix than v1 > > diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c > index f4f30af..2e8a20c 100644 > --- a/drivers/rapidio/rio.c > +++ b/drivers/rapidio/rio.c > @@ -1715,11 +1715,13 @@ int rio_unregister_scan(int mport_id, struct rio_scan > *scan_ops) > (mport_id == RIO_MPORT_ANY && port->nscan == scan_ops)) > port->nscan = NULL; > > - list_for_each_entry(scan, &rio_scans, node) > + list_for_each_entry(scan, &rio_scans, node) { > if (scan->mport_id == mport_id) { > list_del(&scan->node); > kfree(scan); > + break; > } > + } > > mutex_unlock(&rio_mport_list_lock); >
Reviewed-by: Ryan Mallon <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
