On 07/08/2013 05:05 PM, Michael S. Tsirkin wrote: > Jason Wang reported a race in RX VQ processing: > virtqueue_enable_cb is called outside napi lock, > violating virtio serialization rules. > The race has been there from day 1, but it got especially nasty in 3.0 > when commit a5c262c5fd83ece01bd649fb08416c501d4c59d7 > "virtio_ring: support event idx feature" > added more dependency on vq state. > > Please review, and consider for 3.11 and for stable. > > Jason, could you please report whether this fixes the issues for you?
Yes, I confirm this fixes the issue. Since I can only reproduce it by adding udelay in virtqueue_enable_cb() after virtio_mb(). I validate this also with this. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
