On 7/24/2013 1:02 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Wed, Jul 24, 2013 at 12:28:02PM -0400, Rhyland Klein wrote: > >> + /* Store the pdata pointer after everything else passes */ >> + pdev->dev.platform_data = pdata; > > No, this is bad - the driver should not be modifying the platform_data > pointer, it's owned by the thing that created the device. If the > platform data needs to be modified it should be copied somewhere in the > driver data.
Alright, thanks. -rhyland > > * Unknown Key > * 0x7EA229BD > -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
