(7/25/13 8:14 AM), Tom Rini wrote:
> It is posible for some compilers to decide that __node_set does not need
> to be made turned into an inline function. When the compiler does this
> on an __init function calling it on __initdata we get a section mismatch
> warning now.
>
> Reported-by: Paul Bolle <pebo...@tiscali.nl>
> Cc: Jianpeng Ma <majianp...@gmail.com>
> Cc: Rusty Russell <ru...@rustcorp.com.au>
> Cc: Lai Jiangshan <la...@cn.fujitsu.com>
> Cc: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com>
> Cc: Wen Congyang <we...@cn.fujitsu.com>
> Cc: Jiang Liu <jiang....@huawei.com>
> Cc: KOSAKI Motohiro <kosaki.motoh...@jp.fujitsu.com>
> Cc: Minchan Kim <minchan....@gmail.com>
> Cc: Mel Gorman <mgor...@suse.de>
> Cc: David Rientjes <rient...@google.com>
> Cc: Yinghai Lu <ying...@kernel.org>
> Cc: Greg KH <g...@kroah.com>
> Signed-off-by: Tom Rini <tr...@ti.com>
> ---
> include/linux/nodemask.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
> index 4e2cbfa..10d0fd9 100644
> --- a/include/linux/nodemask.h
> +++ b/include/linux/nodemask.h
> @@ -99,7 +99,7 @@ typedef struct { DECLARE_BITMAP(bits, MAX_NUMNODES); }
> nodemask_t;
> extern nodemask_t _unused_nodemask_arg_;
>
> #define node_set(node, dst) __node_set((node), &(dst))
> -static inline void __node_set(int node, volatile nodemask_t *dstp)
> +static __always_inline void __node_set(int node, volatile nodemask_t *dstp)
The change looks ok. But, this code doesn't tell us why you changed. Please
write
down proper comments here.
> {
> set_bit(node, dstp->bits);
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
