On Mon, Jul 29, 2013 at 04:20:03PM +0800, Axel Lin wrote: > 2013/7/29 Axel Lin <[email protected]>: > > Hi Robin, > > 2 questions about the code in pfuze100 driver: > > > > 1) > > Both PFUZE100_REVID and PFUZE100_FABID are defined as 0x3. > > So I'm wondering if it's a typo in one of the register address? > > If they are actually the same register, we don't need to read the same > > register twice in pfuze_identify(). Yes, It's a typo, I will correct it. > > > > 2) > > What is the the purpose of stby_reg and stby_mask? > > Seems current code does not use it? They are only kept place. These reg bits are used to set standby voltage, I will finish it in the future. > > > One more question: > > Current code adjust min_uV and uV_step when SW2~SW4 high bit is set. > I'm wondering if n_voltages is correct or not in this case because > the n_voltages is calculated by original equation (max-min/step + 1). > What is the max_uV when SW2~SW4 high bit is set? > If high bit set(bit6, bit0~5:vsel), min_uV/step will change from 0.4V/25mV to 0.8V/50mV,but the n_voltages will kept the same. For example,SW2 will vary from 0.4V to 1.975V(0x0~0x3f),if bit6 set 0(high bit) SW2 will vary from 0.8V to 3.3V(0x40~0x72,0x72~0x7f:reversed). Please ignore bit7 or consider it as 0. > Regards, > Axel >
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
