Hello, On Mon, Jul 29, 2013 at 03:07:48PM +0800, Li Zefan wrote: > @@ -4590,6 +4599,9 @@ static void cgroup_offline_fn(struct work_struct *work) > /* delete this cgroup from parent->children */ > list_del_rcu(&cgrp->sibling); > > + if (cgrp->id) > + idr_remove(&cgrp->root->cgroup_idr, cgrp->id); > +
Yeap, if we're gonna allow lookups, removal should happen here but can we please add short comment explaining why that is? Also, do we want to clear cgrp->id? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
