On 07/29/2013 07:30 PM, Joe Perches wrote:
> On Mon, 2013-07-29 at 19:22 -0600, Shuah Khan wrote:
>> Add tracing feature to iommu to report various iommu events. Classes
>> iommu_group, iommu_device, iommu_map_unmap, and iommu_amd_event are defined.
>
> Hi again Shuah
>
>> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> []
>> @@ -2159,6 +2160,15 @@ static int iommu_prepare_identity_map(struct pci_dev
>> *pdev,
>> printk(KERN_INFO
>> "IOMMU: Setting identity map for device %s [0x%Lx - 0x%Lx]\n",
>> pci_name(pdev), start, end);
>> +
>> + {
>> + trace_amd_event("Event", 0x1, pdev->devfn, 0, start, 2);
>> + trace_remove_device_from_group(0, &pdev->dev);
>> + trace_attach_device_to_domain(&pdev->dev);
>> + trace_detach_device_from_domain(&pdev->dev);
>> + trace_map(start, end, 1024);
>> + trace_unmap(start, end, 1024);
>> + }
>
> Aren't these parentheses superfluous and
> so the indent too deep too?
>
Hi Joe,
That is the test code, I included by mistake. I had these changes
sitting uncommitted in my tree for testing and I accidentally generated
the patch with them. I am going to send a patch without this file.
I should remember to not rush things at the end of day and create noise. :(
-- Shuah
Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research
America (Silicon Valley) [email protected] | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
