On 07/31, Steven Rostedt wrote: > > On Wed, 2013-07-31 at 22:40 +0200, Oleg Nesterov wrote: > > > > This should be fine. Either event_remove() path takes event_mutex > > first and then ->write() fails, or ftrace_event_enable_disable() > > actually disables this even successfully. > > Actually I meant while in unregister_trace_probe(), it gets by the > trace_probe_is_enabled() part first, then the write succeeds (as the > event_mutex isn't taken till unregister_probe_event()). The the > unregister_probe_event fails,
Yes sure. In this case evrything is clear. But this looks as if unregister_probe_event() should not fail. IOW, this looks as if the bug was introduce by the previous "trace_remove_event_call() should fail if call/file is in use" change. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
