On 2 August 2013 11:20, Jingoo Han <jg1....@samsung.com> wrote: > 'mmc_callback_data' and 'vtg' are pointers. > Fix the following sparse warning: > > drivers/mfd/menelaus.c:445:43: warning: Using plain integer as NULL pointer > drivers/mfd/menelaus.c:469:20: warning: Using plain integer as NULL pointer > > Signed-off-by: Jingoo Han <jg1....@samsung.com> > --- > drivers/mfd/menelaus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c > index 998ce8c..0f62ecd 100644 > --- a/drivers/mfd/menelaus.c > +++ b/drivers/mfd/menelaus.c > @@ -442,7 +442,7 @@ void menelaus_unregister_mmc_callback(void) > menelaus_remove_irq_work(MENELAUS_MMC_S2D1_IRQ); > > the_menelaus->mmc_callback = NULL; > - the_menelaus->mmc_callback_data = 0; > + the_menelaus->mmc_callback_data = NULL; > } > EXPORT_SYMBOL(menelaus_unregister_mmc_callback); > > @@ -466,7 +466,7 @@ static int menelaus_set_voltage(const struct menelaus_vtg > *vtg, int mV, > struct i2c_client *c = the_menelaus->client; > > mutex_lock(&the_menelaus->lock); > - if (vtg == 0) > + if (vtg == NULL)
Instead you could just make this: if (!vtg) > goto set_voltage; > -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/