On Mon, 19 Aug 2013 18:46:32 +0900 Yoshihiro YUNOMAE <[email protected]> wrote:
> Split out the connect waiting loop from do_listen() for avoiding duplicate > codes > between listen mode and virt-server mode. > > Signed-off-by: Yoshihiro YUNOMAE <[email protected]> > --- > trace-listen.c | 45 ++++++++++++++++++++++++++------------------- > 1 file changed, 26 insertions(+), 19 deletions(-) > > diff --git a/trace-listen.c b/trace-listen.c > index 6c1bcac..c741fa4 100644 > --- a/trace-listen.c > +++ b/trace-listen.c > @@ -580,14 +580,35 @@ static void clean_up(int sig) > } while (ret > 0); > } > > +static void do_accept_loop(int sfd) > +{ > + struct sockaddr_storage peer_addr; > + socklen_t peer_addr_len; > + int cfd, pid; Just an FYI, and I don't really care too much. But my personal preference, is to only join variables that are being used the same way. That is, multiple file descriptors sure: int sfd, s, cfd; But I prefer to keep file descriptors separate from pid. int cfd; int pid; But as I said, this is only a preference and I don't really care that much about it to even bother to change the patch. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
