David Rientjes wrote: > On Wed, 21 Aug 2013, Kirill A. Shutemov wrote: > > > David Rientjes wrote: > > > Currently, thp_fault_fallback in vmstat only gets incremented if a > > > hugepage allocation fails. If current's memcg hits its limit or the page > > > fault handler returns an error, it is incorrectly accounted as a > > > successful thp_fault_alloc. > > > > > > Count thp_fault_fallback anytime the page fault handler falls back to > > > using regular pages and only count thp_fault_alloc when a hugepage has > > > actually been faulted. > > > > > > Signed-off-by: David Rientjes <[email protected]> > > > > It's probably a good idea, but please make the behaviour consistent in > > do_huge_pmd_wp_page() and collapse path, otherwise it doesn't make sense. > > > > The collapse path has no fallback, the allocation either succeeds or it > fails.
THP_COLLAPSE_ALLOC should be counted after successful memcg charge or even only after successful collapse. -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
