> From: Wei Yongjun [mailto:weiyj...@gmail.com] > Sent: Friday, August 23, 2013 10:48 AM > To: ax...@kernel.dk; a...@linux-foundation.org; Caizhiyong; k...@redhat.com; > m...@sysgo.de; dw...@infradead.org; computersforpe...@gmail.com; > dedek...@infradead.org > Cc: yongjun_...@trendmicro.com.cn; linux-kernel@vger.kernel.org > Subject: [PATCH -next] block: fix error return code in parse_parts() > > From: Wei Yongjun <yongjun_...@trendmicro.com.cn> > > Fix to return -EINVAL in the parts parse error handling case instead > of 0(may overwrite to 0 by parse_subpart()), as done elsewhere in this > function. > > Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn> > --- > block/cmdline-parser.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/cmdline-parser.c b/block/cmdline-parser.c > index 18fb435..cc2637f 100644 > --- a/block/cmdline-parser.c > +++ b/block/cmdline-parser.c > @@ -135,6 +135,7 @@ static int parse_parts(struct cmdline_parts **parts, > const char > *bdevdef) > > if (!newparts->subpart) { > pr_warn("cmdline partition has no valid partition."); > + ret = -EINVAL;
Seems OK to me. > goto fail; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
