Hi Andrzej, On Wednesday 21 of August 2013 18:53:34 Andrzej Hajda wrote: > This patch adds only of_match_table. > There are no device specific properties. > > Signed-off-by: Andrzej Hajda <[email protected]> > Reviewed-by: Sylwester Nawrocki <[email protected]> > Signed-off-by: Kyungmin Park <[email protected]> > --- > drivers/mfd/max77693.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index 27f5da3..e0b11a9 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -225,11 +225,19 @@ static const struct dev_pm_ops max77693_pm = { > .resume = max77693_resume, > }; > > +#ifdef CONFIG_OF > +static struct of_device_id max77693_dt_match[] = { > + {.compatible = "maxim,max77693"}, > + {}, > +}; > +#endif > + > static struct i2c_driver max77693_i2c_driver = { > .driver = { > .name = "max77693", > .owner = THIS_MODULE, > .pm = &max77693_pm, > + .of_match_table = of_match_ptr(max77693_dt_match),
As far as I'm aware of, you don't need explicit OF match table for I2C devices, because the I2C OF core can use the array of struct i2c_device_id pointed by .id_table field of struct i2c_driver. I'm not sure if a separate OF table isn't preferred, though, so your patch might be fine. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
