Some minor nitpicking, nothing much :)
On 13 August 2013 15:38, Lukasz Majewski <l.majew...@samsung.com> wrote:
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> +static int cpufreq_boost_set_sw(int state)
> +{
> + struct cpufreq_frequency_table *freq_table;
> + struct cpufreq_policy *policy;
> + int ret = -EINVAL;
> +
> + list_for_each_entry(policy, &cpufreq_policy_list, policy_list) {
> + freq_table = cpufreq_frequency_get_table(policy->cpu);
> + if (freq_table) {
> + ret = cpufreq_frequency_table_cpuinfo(policy,
> + freq_table);
> + if (!ret) {
> + policy->user_policy.max = policy->max;
> + __cpufreq_governor(policy,
> CPUFREQ_GOV_LIMITS);
> + }
In case ret wasn't 0 (i.e. we failed), we should print an error
message and break
our loop ?
> + }
> + }
> +
> + return ret;
> +}
> +
> +int cpufreq_boost_trigger_state(int state)
> +{
> + unsigned long flags;
> + int ret = 0;
> +
> + if (cpufreq_driver->boost_enabled == state)
> + return 0;
> +
> + write_lock_irqsave(&cpufreq_driver_lock, flags);
> + cpufreq_driver->boost_enabled = state;
> + write_unlock_irqrestore(&cpufreq_driver_lock, flags);
> +
> + ret = cpufreq_driver->set_boost(state);
> + if (ret) {
> + write_lock_irqsave(&cpufreq_driver_lock, flags);
> + cpufreq_driver->boost_enabled = !state;
> + write_unlock_irqrestore(&cpufreq_driver_lock, flags);
> +
> + pr_err("%s: Cannot %s BOOST\n", __func__,
> + state ? "enabled" : "disabled");
s/enabled/enable and s/disabled/disable
> + }
> +
> + return ret;
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
