On Mon, Sep 02, 2013 at 08:33:44PM +0800, Wanpeng Li wrote: > The lack of one reference count against poisoned page for hwpoison_inject w/o > hwpoison_filter enabled result in hwpoison detect -1 users still referenced > the page, however, the number should be 0 except the poison handler held one > after successfully unmap. This patch fix it by hold one referenced count > against > poisoned page for hwpoison_inject w/ and w/o hwpoison_filter enabled. > > Before patch: > > [ 71.902112] Injecting memory failure at pfn 224706 > [ 71.902137] MCE 0x224706: dirty LRU page recovery: Failed > [ 71.902138] MCE 0x224706: dirty LRU page still referenced by -1 users > > After patch: > > [ 94.710860] Injecting memory failure at pfn 215b68 > [ 94.710885] MCE 0x215b68: dirty LRU page recovery: Recovered > > Signed-off-by: Wanpeng Li <[email protected]>
Reviewed-by: Naoya Horiguchi <[email protected]> > --- > mm/hwpoison-inject.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c > index afc2daa..4c84678 100644 > --- a/mm/hwpoison-inject.c > +++ b/mm/hwpoison-inject.c > @@ -20,8 +20,6 @@ static int hwpoison_inject(void *data, u64 val) > if (!capable(CAP_SYS_ADMIN)) > return -EPERM; > > - if (!hwpoison_filter_enable) > - goto inject; > if (!pfn_valid(pfn)) > return -ENXIO; > > @@ -33,6 +31,9 @@ static int hwpoison_inject(void *data, u64 val) > if (!get_page_unless_zero(hpage)) > return 0; > > + if (!hwpoison_filter_enable) > + goto inject; > + > if (!PageLRU(p) && !PageHuge(p)) > shake_page(p, 0); > /* > -- > 1.8.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
