On Mon, Sep 02, 2013 at 02:11:36PM -0700, Joe Perches wrote: > On Mon, 2013-09-02 at 21:50 +0100, David Howells wrote: > > Josh Triplett <j...@joshtriplett.org> wrote: > > > > > > There are many checkpatch rules (like semicolons) that > > > > are not in CodingStyle. > > > > > > It's a rule of thumb, not a mandate. In *general*, checkpatch.pl should > > > not be enforcing style rules that aren't documented in CodingStyle. > > > > Except that it becomes a mandate when someone runs it automatically against > > every one of your patches and then sends you an email for each patch it > > finds > > a checkpatch niggle against... > > I think that any robot sending such checkpatch-only > emails should be disabled. > > I know of 2 email robots. > > Fengguang Wu's very useful build robot > sends out emails on build failures. > I think that's great.
Thanks! Yes I'm now running checkpatch these days because some people suggested to me that some of the checkpatch warnings do help catch real bugs. However I do try to avoid upsetting people with maybe-subjective warnings. A checkpatch report will only be sent when a small fraction of error types are detected. Comments are very welcome on how to improve this list: MEMSET IN_ATOMIC UAPI_INCLUDE MALFORMED_INCLUDE SIZEOF_ADDRESS KREALLOC_ARG_REUSE EXECUTE_PERMISSIONS ERROR:BAD_SIGN_OFF LO_MACRO HI_MACRO CSYNC SSYNC HOTPLUG_SECTION INDENTED_LABEL INLINE_LOCATION STORAGE_CLASS USLEEP_RANGE UNNECESSARY_CASTS ALLOC_SIZEOF_STRUCT KREALLOC_ARG_REUSE USE_FUNC LOCKDEP EXPORTED_WORLD_WRITABLE WHITESPACE_AFTER_LINE_CONTINUATION MISSING_VMLINUX_SYMBOL NEEDLESS_IF PRINTF_L Once the decision is made to send a checkpatch error/warning, the report email will use the triggering error (the one that matters) as the email subject, with the complete output of checkpatch.pl included in email body. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/