On Tue, 2013-09-03 at 10:09 -0400, Jerome Oufella wrote:
> As pointed out by Paul Bolle in https://lkml.org/lkml/2012/9/24/221, the
> fast TSC calibration method may fail on some machines and result in an
> error level message that does not reflect the severity of the case.
> 
> Signed-off-by: Jerome Oufella <[email protected]>
> ---
> This patch lost momentum and wordsmithing the message was evoked in
> subsequent posts but imho reducing the level does the job just fine.

I've carried an identical patch locally ever since I submitted the patch
referenced by Jerome. Ie, I'm now running v3.11 with that patch applied.
Jerome's commit explanation is a bit terse when compared to my
verbosity, but otherwise I'm fine with this. So:

Acked-by: Paul Bolle <[email protected]>


Paul Bolle
> ---
>  arch/x86/kernel/tsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index 6ff4924..e518724 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -380,7 +380,7 @@ static unsigned long quick_pit_calibrate(void)
>                       goto success;
>               }
>       }
> -     pr_err("Fast TSC calibration failed\n");
> +     pr_info("Fast TSC calibration failed\n");
>       return 0;
>  
>  success:

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to