On Sat, Sep 7, 2013 at 10:52 PM, Ben Hutchings <[email protected]> wrote: > > 3.2.51-rc1 review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Chen Gang <[email protected]> > > commit 057d6332b24a4497c55a761c83c823eed9e3f23b upstream. > > For cifs_set_cifscreds() in "fs/cifs/connect.c", 'desc' buffer length > is 'CIFSCREDS_DESC_SIZE' (56 is less than 256), and 'ses->domainName' > length may be "255 + '\0'". > > The related sprintf() may cause memory overflow, so need extend related > buffer enough to hold all things. > > It is also necessary to be sure of 'ses->domainName' must be less than > 256, and define the related macro instead of hard code number '256'. > > Signed-off-by: Chen Gang <[email protected]> > Reviewed-by: Jeff Layton <[email protected]> > Reviewed-by: Shirish Pargaonkar <[email protected]> > Reviewed-by: Scott Lovenberg <[email protected]> > Signed-off-by: Steve French <[email protected]> > [bwh: Backported to 3.2: > - Adjust context in sess.c > - Drop inapplicable changes to connect.c] > Signed-off-by: Ben Hutchings <[email protected]>
Looks good to me. -- Peace and Blessings, -Scott. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
